[Webkit-unassigned] [Bug 34524] [Chromium] Writing Direction context menu for OS X

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34524


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org




--- Comment #6 from David Levin <levin at chromium.org>  2010-02-03 07:13:47 PST ---
(In reply to comment #4)
> I think the error about header order is erroneous, if not I'd be
> grateful if someone could point out what to change.

WebKit sorts headers in a case sensitive manner and ascii('S') < ascii('o'), so
the headers should be ordered llke this:
   #include "CSSPropertyNames.h"
   #include "CSSStyleDeclaration.h"
   #include "ContextMenu.h"

Two other nits:

  You have a two space indent instead of four on the contents of the enum in
WebContextMenuData.h

  I Am Not Sure Why The Comment Is Written Like This as opposed to a normal
sentence capitalization. "// Writing Direction Context Menu."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.