[Webkit-unassigned] [Bug 30245] [Chromium] Decoration of "search" input field is wrongly rendered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30245





--- Comment #12 from Yuta Kitamura <yutak at chromium.org>  2010-02-03 01:44:04 PST ---
(In reply to comment #11)
> (From update of attachment 47502 [details])
> I don't understand why you're adding all the const declarations?  That's
> unrelated to this patch and should not be part of this.  WebKit seems to have
> mixed feelings on the value of const anyway.

It's because the first argument of
RenderThemeChromiumSkia::convertToPaintingRect 
is marked as const. The signature of this function is originally taken from
RenderThemeMac::convertToPaintingRect, whose first argument is also marked as
const.

I can certainly strip away these consts, but, to be honest, I really think
there is no reason to leave the arguments of offsetContainer non-const.
I believe it's common and important in C++ to distinguish const pointer
variables
from non-const ones.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.