[Webkit-unassigned] [Bug 34509] Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34509


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com

Yaar Schnitman <yaar at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47986|Patch                       |Patch 2
        description|                            |
  Attachment #47986|                            |commit-queue?
               Flag|                            |




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-02-02 18:39:24 PST ---
Attachment 47985 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/tests/TransparencyWinTest.cpp:33:  Found other header before a
header this file implements. Should be: config.h, primary header, blank line,
and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:36:  Alphabetical sorting
problem.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:38:  Found header this file
implements after other header. Should be: config.h, primary header, blank line,
and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:33:  Found other header before a
header this file implements. Should be: config.h, primary header, blank line,
and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:35:  Alphabetical sorting
problem.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:36:  Found header this file
implements after other header. Should be: config.h, primary header, blank line,
and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.