[Webkit-unassigned] [Bug 34489] [Qt] Text codec lookup is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34489


Ariya Hidayat <ariya.hidayat at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47978|review?                     |review-
               Flag|                            |




--- Comment #5 from Ariya Hidayat <ariya.hidayat at gmail.com>  2010-02-02 16:59:00 PST ---
(From update of attachment 47978)

> +        QtTextCodec creation is very slow
> +        https://bugs.webkit.org/show_bug.cgi?id=34489

Better to describe the solution rather than only the problem.
Maybe something like "[Qt] Text codec caching to speed up codec look-up".

> +typedef QHash<QString, QTextCodec*> TextCodecHash;
> +static TextCodecHash textCodecCache;

I guess static problem with RVCT 2.2 has been solved in the past. Maybe Laszlo
knows this?

> +    // qDebug() << "TextCodecQt::TextCodecQt() - " << name;

Do we want this?

BTW, try to ask Simon about his opinion, he's the text expert :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.