[Webkit-unassigned] [Bug 34492] avoid using invalidated KURL object in Element::baseURI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 11:25:41 PST 2010


--- Comment #9 from Darin Adler <darin at apple.com>  2010-02-02 11:25:40 PST ---
(In reply to comment #8)
> Sorry for the incomplete patch last time.  This includes the ChangeLog entry. 
> There was already a test failing on Chromium without this change
> (LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg), so I do not think an
> additional regression test is necessary.

Typically a patch would include the corrected results or a change to the
skipped list for a patch -- so I could see what test was changing behavior. But
since Chromium has a different way of doing things, maybe that's why there's no
such change here.

Despite the fact that a test was failing, a simpler test that targets this
behavior more directly would be far better. It could even be a dumpAsText test.

Tests where success can only be judged from the pixel results are the lowest on
our totem pole of test usefulness, so this existing test is only barely

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list