[Webkit-unassigned] [Bug 34492] avoid using invalidated KURL object in Element::baseURI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34492


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47952|review?                     |review-
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2010-02-02 11:05:24 PST ---
(From update of attachment 47952)
Change looks great, although I’d probably use assignment syntax rather than
initialization to set up the baseAttribute local variable.

Generally it's not correct to set the review flag on a patch without a change
log entry.

We require regression tests for bugs fixes. Since this patch fixes a bug, you
must also include a regression test that fails on Chromium before this change
and now succeeds with the fix. But neither the test itself nor the test results
should be Chromium-specific.

review- because of the lack of change log and regression test

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.