[Webkit-unassigned] [Bug 34409] Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 11:01:44 PST 2010


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #47951|review?, commit-queue?      |review+
               Flag|                            |

--- Comment #9 from Darin Adler <darin at apple.com>  2010-02-02 11:01:44 PST ---
(From update of attachment 47951)
> +using WTF::getLocalTime;

Thanks for changing this, but it's still not quite right. This needs to go at
the bottom of CurrentTime.h with the other "using" that is already there. But
as I said last time, I will not insist it goes there in this patch. It might be
more pleasant to have this patch not touch JavaScriptCore.

>  #if PLATFORM(QT) && defined(Q_WS_WIN32)
> -// Defined in FTPDirectoryDocument.cpp.
> -struct tm gmtimeQt(const QDateTime &input);
> +
> +// Replacement for gmtime_r() which is not available on MinGW.
> +// We use this on all of Qt's platforms for portability.

The code above says "use this only on Win 32", but the comment says "on all of
Qt's platforms". The comment should match the #if.

r=me because I think it's OK to land even with these mistakes, but I cleared
commit-queue because I think we'll probably go another round

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list