[Webkit-unassigned] [Bug 34492] avoid using invalidated KURL object in Element::baseURI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34492





--- Comment #2 from Darin Adler <darin at apple.com>  2010-02-02 10:57:53 PST ---
Please be clear, holding arbitrary strings that are not valid URLs is an
intentional feature of KURL. To remove it we need to remove all clients that
depend on that. It sure would be great to have the freedom to not need that
feature, but we can’t get that by just fixing the cases we have already
stumbled on, we need to look at all callers.

And then change the implementation so the mistake is easy to detect.

I know that Chromium has been living with all these bugs all along since
KURLGoogle omitted that feature, but when fixing this please keep in mind that
all other platforms have not been subject to the bugs.

KURLGoogle still seems like a bad idea to me. I know it’s pleasant for Chromium
to share the same URL parsing with the other components in Chromium -- it would
be nice to have that on the Mac too -- and someone may have the idea that it
helps with security, but I believe that for the WebKit project as a whole would
be great to make changes as needed to both the original KURL and KURLGoogle so
their behavior is identical and then get rid of this unnecessary difference
between platforms by deleting KURLGoogle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.