[Webkit-unassigned] [Bug 34409] Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 10:41:33 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34409


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47949|commit-queue+               |commit-queue?
               Flag|                            |




--- Comment #6 from Brady Eidson <beidson at apple.com>  2010-02-02 10:41:33 PST ---
(From update of attachment 47949)
I don't know the full structure of this code off-hand nor do I understand the
specific reasons why QT is so special here.  It appears on the surface that the
FTPDocument or FTPParser code is utterly the wrong place for any time-related
methods.  It seems like such fundamental platform code that the other platforms
use WTF:: functions for should be made to live in WTF.

That said, the damage was already done and I'm not going to make you change it
here.  Please consider spending a little time to consolidate it to a different
place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list