[Webkit-unassigned] [Bug 34409] Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 10:04:39 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34409





--- Comment #3 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2010-02-02 10:04:39 PST ---
>From the code comment, it seems localTimeQt was needed because MinGW lacks
localtime_r.  As WTF::getLocalTime already covers COMPILER(MINGW), I guess it
is safe to remove the entire platform guards and can replace localtime_r with
WTF::getLocalTime.

However, the helper function gmtimeQt(const QDateTime &input) is shared by
FTPDirectoryParser.cpp to implement gmTimeQt(const time_t *const timep, struct
tm *result), so I couldn't remove it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list