[Webkit-unassigned] [Bug 34474] Share the DRT values maxViewWidth/Height among ports

Tue Feb 2 10:03:03 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=34474

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47925|review?                     |review-
               Flag|                            |

--- Comment #3 from Darin Adler <darin at apple.com>  2010-02-02 10:03:03 PST ---
(From update of attachment 47925)
Good goal. But why not share these in a header as plain old C++ constants? It
seems wrong to put these into config.h as macros. Macros are deprecated and
should only be used when there is no better solution. And config.h should be
kept as simple as possible. We're working longer term to simplify further.

I suggest we just move maxViewWidth and maxViewHeight from DumpRenderTree.mm
into LayoutTestController.h and use those in LayoutTestController.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.