[Webkit-unassigned] [Bug 34471] [Chromium] Implement WebFrameImpl::pageNumberForElementById

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34471


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-02-02 04:40:24 PST ---
Attachment 47921 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebFrameImpl.h:168:  page_width_in_pixels is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebKit/chromium/src/WebFrameImpl.h:169:  page_height_in_pixels is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebKit/chromium/src/WebFrameImpl.cpp:1522:  page_width_in_pixels is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebKit/chromium/src/WebFrameImpl.cpp:1523:  page_height_in_pixels is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebKit/chromium/src/WebFrameImpl.cpp:1532:  page_size is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/chromium/public/WebFrame.h:490:  page_width_in_pixels is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebKit/chromium/public/WebFrame.h:491:  page_height_in_pixels is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
Total errors found: 7


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.