[Webkit-unassigned] [Bug 34435] [Gtk] libsoup critical warning in media player http cookies injection code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34435


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47916|review?                     |review-
               Flag|                            |




--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-02 04:16:56 PST ---
(From update of attachment 47916)
 8         * GNUmakefile.am: Added libsoup and gstreamer CFLAGS/LDFLAGS to
JavascriptCore build.

This is a bad thing we want to avoid. JSC should not need to depend on those.
For GRefPtr mrobinson added files to WebCore/platform/gtk. I think this is the
way to go for these GOwnPtr types.

 11         not be done neither the User-Agent not Referer were injected.

s/not/nor/

 142     char* location;
 143     g_object_get(element.get(), "location", &location, NULL);
 144 
 145     GOwnPtr<SoupURI> uri(soup_uri_new(location));
 146     g_free(location);

You could use GOwnPtr for char* location, and the other char*'s in this code,
by the way!

r- for the addition of unneeded deps on JSC.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.