[Webkit-unassigned] [Bug 34460] [Chromium] Add WebSecurityOrigin::createFromString factory
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 1 22:55:06 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=34460
Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47894|review? |review-
Flag| |
--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2010-02-01 22:55:06 PST ---
(From update of attachment 47894)
> Index: WebKit/chromium/public/WebSecurityOrigin.h
> WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& databaseIdentifier);
> + WEBKIT_API static WebSecurityOrigin* createFromString(const WebString& origin);
There's no reason for either of these to return pointers.
WebSecurityOrigin is already like a smart pointer class. Just return by value.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list