[Webkit-unassigned] [Bug 30144] MIPS JIT Supports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30144


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #40 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-02-01 17:25:29 PST ---
Attachment 47887 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
orrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
JavaScriptCore/wtf/Platform.h:109:  More than one command on the same line in
if  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:650:  Extra space before ( in function call 
[whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:689:  Extra space before ( in function call 
[whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:718:  Extra space before ( in function call 
[whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:1149:  Extra space before ( in function call 
[whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:1175:  Extra space before ( in function call 
[whitespace/parens] [4]
JavaScriptCore/assembler/MacroAssembler.h:43:  More than one command on the
same line  [whitespace/newline] [4]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:35:  Alphabetical sorting
problem.  [build/include_order] [4]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:239:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:259:  shift_amount is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:271:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:297:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:314:  shift_amount is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:693:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:708:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:736:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
JavaScriptCore/assembler/MacroAssemblerMIPS.h:804:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
JavaScriptCore/jit/JITOpcodes.cpp:1776:  Tests for true/false, null/non-null,
and zero/non-zero should all be done without equality comparisons. 
[readability/comparison_to_zero] [5]
JavaScriptCore/jit/ExecutableAllocator.h:202:  line_size is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/jit/ExecutableAllocator.h:203:  Extra space before ( in function
call  [whitespace/parens] [4]
Total errors found: 57


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.