[Webkit-unassigned] [Bug 21840] execCommand insertImage inserts image into wrong place

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21840





--- Comment #18 from Tony Chang (Google) <tony at chromium.org>  2010-02-01 16:52:17 PST ---
(In reply to comment #17)
> I'm not suggesting that you leave a placeholder all the time. 
> If you limit the scope of the change to DeleteSelection to only cases where the
> lack of a placeholder leads to ambiguity about where to insert the new content,
> you should be fine.

Right, I tried that.  I added a flag to DeleteSelection and only set the flag
in ReplaceSelectionCommand.cpp when needed.  One example problem is that when
you press the delete key, this calls DeleteSelectionCommand::doApply, which
calls DeleteSelectionCommand::mergeParagraphs, which calls
CompositeEditCommand::moveParagraphs which calls ReplaceSelectionCommand which
causes the extra BR to be inserted.  In this case, we don't want a BR since
we're just deleting.

If you think it's worthwhile, I will resurrect the patch and upload it for
comparison.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.