[Webkit-unassigned] [Bug 34323] [BREWMP] Port FileSystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34323





--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-02-01 15:54:17 PST ---
(From update of attachment 47697)
Given how often you use this in various places, seems you might want to add it
to a common header at some point:
 49     IShell* shell =
reinterpret_cast<AEEApplet*>(GETAPPINSTANCE())->m_pIShell;

This seems like  a bad idea:
 47 static PassOwnPtr<IFileMgr> createIFileMgr()

can you actually call "delete" with an IFileMgr pointer ant it will do the
right thing?  It doesn't need some special release call?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.