[Webkit-unassigned] [Bug 33630] SVG not rendered as background-image from data URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33630





--- Comment #8 from Yael <yael.aharon at nokia.com>  2010-02-01 13:08:31 PST ---
(In reply to comment #7)
> (From update of attachment 47856 [details])
> FloatRect has a constructor which takes a point and a size.  That would be
> cleaner than using size.width() size.height().
> 
> "r" is not a very good variable name.
> 
> Are you sure that rect() isn't already implemented in Image.h anyway?
> 
> Why should draw() be used explicitly instead of renderSubtreeToImage changed?

Thank you for the review, Eric. 
I chose to use draw() instead of modifying renderSubTreeToImage() to be
consistent with the behavior when the SVG is bigger than the background it
covers. I could probably use renderSubTreeToImage() if instead of passing the
RenderView, I would walk the render tree, and find the correct renderer to pass
to renderSubTreeToImage().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.