[Webkit-unassigned] [Bug 34434] [Android] AbstractWeakReferenceMap in V8DOMMap.h needs a virtual destructor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34434





--- Comment #7 from Steve Block <steveblock at google.com>  2010-02-01 10:50:28 PST ---
> + virtual ~Visitor
> 
> that's not correct.  Objects are never deleted via Vistor pointers and
> inheriting from the Visitor interface shouldn't force an object to have a
> virtual destructor.  I feel like we had that discussion on another bug and
> found another solution.
Are you thinking of Bug 33675 and http://trac.webkit.org/changeset/53401 ? This
added a virtual destructor to WeakReferenceMap::Visitor. It was the last change
to this file before http://trac.webkit.org/changeset/53944 removed
WeakReferenceMap::Visitor and added AbstractWeakReferenceMap::Visitor. The
outcome of the discussion was to make the destructor protected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.