[Webkit-unassigned] [Bug 30004] [GStreamer] Should handle BUFFERING messages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30004


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46056|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #23 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-01 08:43:31 PST ---
(From update of attachment 46056)
 680     // Don't bother drawing an empty area.
 681     if (!bufferedRect.isEmpty()) {

This should be an early return for the true case instead.

7  Time: 2.2
 7 Time: 2.1

Why has this changed?

Patch looks good, overall, so just change the if to an early return, please,
and add a comment regarding the change in drag-timebar.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.