[Webkit-unassigned] [Bug 34170] [Qt] Javascript undefined > 0 returns true on Symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34170


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47838|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #9 from Darin Adler <darin at apple.com>  2010-02-01 07:40:32 PST ---
(From update of attachment 47838)
> +#if PLATFORM(QT)
> +#include <qnumeric.h>
> +#endif

Includes with ifdefs go into a separate paragraph. Not sorted into the normal
includes.

The ifdef should definitely be for Symbian rather than for Qt. This patch is
all about working around a Symbian bug. And I am also really surprised it's
broken!

> +    return qQNaN();

This seems OK, but ideally we'd work around the Symbian bug without requiring
Qt here. Is there any other way to do it? For example, does 0.0 / 0.0 work? Or
is there an NAN macro on Symbian?

review- but something like this would be fine -- just please consider my
comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.