[Webkit-unassigned] [Bug 34416] [Qt] Build without SSL support is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34416





--- Comment #7 from Henry Haverinen <henry.haverinen at nokia.com>  2010-02-01 07:07:42 PST ---
(In reply to comment #5)
> (From update of attachment 47839 [details])
> You need to put the patch up for review, I have done so now.
> > +    } else
> >          m_socket = new QTcpSocket(this);
> > +
> > +    if (!m_socket)
> > +        return;
> Why did you add this early return. The new is supposed to return something
> valid, unless we are out of memory.

The return is not related to the new just above it, but to an #ifndef'd new
above it. Without SSL support, there's no way to create a valid socket for this
case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.