[Webkit-unassigned] [Bug 34416] [Qt] Build without SSL support is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34416


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47839|                            |review?
               Flag|                            |




--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-02-01 07:02:18 PST ---
(From update of attachment 47839)
You need to put the patch up for review, I have done so now.


> +    } else
>          m_socket = new QTcpSocket(this);
> +
> +    if (!m_socket)
> +        return;

Why did you add this early return. The new is supposed to return something
valid, unless we are out of memory.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.