[Webkit-unassigned] [Bug 33044] Add Java Applet support to WebKit's Qt port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 06:41:38 PST 2010


--- Comment #5 from Garth Dahlstrom <ironstorm at gmail.com>  2010-02-01 06:41:38 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > @Kenneth
> > Here is the the patch run through check-webkit-style and with qDebug()'s
> > replaced with LOG statements (hoping that is the right thing to replace
> > qDebug's with).   Note: I did not fix all of the check-webkit-style issues for
> > the class, there are numerous issues that were present in the original classes,
> > I just made sure any new code does not add to the check-webkit-style issues
> > list... 
> That is why you can make check-webkit-style only check what you changed and not
> the file itself. Please check its arguments. If you use git you can do 
> check-webkit-style --git-index=<GIT-HASH>

--git-index=eb3afcbfb4006de4015047555cb256fcde93b954 FrameLoaderClientQt.cpp 

Syntax: check-webkit-style [--verbose=#] [--git-commit=<SingleCommit>]
        [--filter=-x,+y,...] [file] ...

It doesn't matter anyway, there weren't that many style violations to track
them by hand looking by running check-webkit-style against the original and
then the new.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list