[Webkit-unassigned] [Bug 34378] [Qt] WinCE buildfix after r52729

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34378





--- Comment #5 from Patrick R. Gansterer <paroga at paroga.com>  2010-02-01 04:31:11 PST ---
(In reply to comment #4)
> The patch looks good to me, although the comment says:
> 
>    We can not determine the endianess at compile time.
> 
> If this comment is not valid anymore, please remove or modify it. Furthermore,
> please do not set commit‑queue flags in the future. It should only be enabled
> after your patch is accepted.
Currently i compile JSC without Qt. Platform.h "dedects" MIDDLE_ENDIAN which is
wrong! So i think the comment is valid.

I want to change this to the following in a further patch:
#if OS(WINCE)
#   undef WTF_CPU_BIG_ENDIAN
#   undef WTF_CPU_MIDDLE_ENDIAN
#   if PLATFORM(QT)
#       include <QtGlobal>
#       if Q_BYTE_ORDER == Q_BIG_ENDIAN
#           define WTF_CPU_BIG_ENDIAN 1
#       endif
#   endif
#   include <ce_time.h>
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.