[Webkit-unassigned] [Bug 51734] [Gtk] null ptr crash in DumpRenderTreeSupportGtk::getInnerText

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51734


Abhishek Arya <inferno at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[Gtk?]                      |[Gtk] null ptr crash in
                   |fast/multicol/span/double-m |DumpRenderTreeSupportGtk::g
                   |erge-anonymous-block-crash. |etInnerText
                   |html null ptr crash         |
                 CC|                            |tonikitoo at webkit.org




--- Comment #2 from Abhishek Arya <inferno at chromium.org>  2010-12-30 22:10:08 PST ---
Martin, i compiled a gtk checkout. This testcase does not crash in GtkLauncher. This looks like a issue specific to DumpRenderTreeSupportGtk. Can anyone from gtk team fix this. The reason for the crash probably is that anonymous blocks are essentially null nodes. So, it does look like there is a null check needed at line 145.

CString DumpRenderTreeSupportGtk::getInnerText(WebKitWebFrame* frame)
132    {
133        g_return_val_if_fail(WEBKIT_IS_WEB_FRAME(frame), CString(""));
134    
135        Frame* coreFrame = core(frame);
136        if (!coreFrame)
137            return CString("");
138    
139        FrameView* view = coreFrame->view();
140    
141        if (view && view->layoutPending())
142            view->layout();
143    
144        Element* documentElement = coreFrame->document()->documentElement();
145        return documentElement->innerText().utf8();

ccing tonikitoo at webkit.org who wrote this code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.