[Webkit-unassigned] [Bug 51716] [GTK] Initial build support for WebGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51716





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2010-12-30 13:21:50 PST ---
(In reply to comment #2)

Thanks for the review!

> In general looks fine, but needs more explanation (in code) as to what is permenant and what is temporary? (if any).  In general looks fine.

Everything in this patch is permanent, barring unforseen circumstances. :)

> > WebCore/platform/graphics/GraphicsContext3D.h:70
> > +#undef VERSION
> > +#undef None

I've dropped a comment about this in the second version of this patch and removed the #undef None, which is not necessary yet.

> > WebCore/platform/graphics/GraphicsContext3D.h:74
> > +typedef unsigned int GLuint;
> > +typedef void* PlatformGraphicsContext3D;
> > +const PlatformGraphicsContext3D NullPlatformGraphicsContext3D = 0;
> > +typedef GLuint Platform3DObject;
> Should these be shared between implementations?  Seems they all define he same...

I posted a new version of the patch, which consolidates the similar typedefs. This sacrifices a little bit of clarity for less repitition, but it's a decent tradeoff in my opinion. Let me know which version of the patch you prefer. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.