[Webkit-unassigned] [Bug 40086] Easier to find line numbers to CSS declarations corresponding to source file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40086





--- Comment #5 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2010-12-30 10:00:11 PST ---
(From update of attachment 58285)
View in context: https://bugs.webkit.org/attachment.cgi?id=58285&action=review

I'll leave it to reviewers to decide (I'm not a reviewer), but still, these comments are good to address. Thanks for the patch!

> WebCore/inspector/front-end/inspector.js:1713
> +        var linkText = linkText.split('\\').pop().split('/').pop();

Why both types of slash are used here? AFAIK, only '/'s are used in URLs.

On a side note, we use double-quotes (") rather than apostrophes (') in string literals.

> WebCore/inspector/front-end/inspector.js:1715
> +            linkText = linkText.substring(0, 4) + "..." + linkText.substring(linkText.length - 8, linkText.length);

The "linkText.length" parameter is not necessary as it defaults to the receiver string's length.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.