[Webkit-unassigned] [Bug 48511] [GTK] Implement Process/Thread Launcher classes and WebProcessGtkMain for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48511


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72686|review?                     |review-
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2010-12-30 09:35:03 PST ---
(From update of attachment 72686)
View in context: https://bugs.webkit.org/attachment.cgi?id=72686&action=review

Looks good! Some comments below.

> WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:55
> +    String commandLine(WEBKIT_WEB_PROCESS_PATH);

I don't understand why you are using a String here. Why not just use WEBKIT_WEB_PROCESS_PATH below?

> WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:68
> +        ASSERT_NOT_REACHED();
> +    }

I think it's better to try to handle the error here somehow, even if it's just printing a message.

> WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:81
> +    notImplemented();

Is this not implemented or simply an empty implementation?

> WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:43
> +    // FIXME: Implement.

This looks like a good place for notImplemented() :) I think this file is also missing stubs for platformShutdown and platformClearResourceCaches.

> WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:54
> +    g_type_init();

Do you also need to call g_thread_init() here? Only after 2.24 does g_type_init() call g_thread_init().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.