[Webkit-unassigned] [Bug 51134] Move loading related code from MemoryCache to CachedResourceLoader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51134


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76761|review?                     |review+
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2010-12-29 16:47:08 PST ---
(From update of attachment 76761)
View in context: https://bugs.webkit.org/attachment.cgi?id=76761&action=review

> WebCore/css/CSSImageValue.cpp:75
> +        CachedImage* cachedImage = loader->requestImage(url);
>          if (cachedImage) {

Could put the definition inside the if statement.

> WebCore/loader/cache/CachedResource.h:54
> +    friend class CachedResourceLoader;

Is this really necessary? Can we do something to avoid it?

> WebCore/loader/cache/CachedResourceLoader.cpp:74
> +    default:
> +        break;

Normally we try to avoid having a default. That way, the compiler will warn us if we forget to include a case. Just leaving out "default: break" should do the trick.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.