[Webkit-unassigned] [Bug 51695] New: check-webkit-style treated some macros with parentheses after #elif as function calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51695

           Summary: check-webkit-style treated some macros with
                    parentheses after #elif as function calls
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: koansin.tan at gmail.com
                CC: mrowe at apple.com, levin at chromium.org,
                    mrobinson at webkit.org


I ran into this problem when I tried
    #elif (OS(LINUX) && PLATFORM(CHROMIUM)) || (OS(DARWIN) && !PLATFORM(CF))
The message is like:
   WebCore/platform/UUID.cpp:46:  Extra space before ( in function call  [whitespace/parens] [4]

I tried a bit and found that simply
   #elif (OS(LINUX))
will have the problem. As David Levin pointed out in comments 26 of bug 50867,  the issue is in the regex below from Tools/Scripts/webkitpy/style/checkers/cpp.py 

1340            if (search(r'\w\s+\(', function_call)
1341                and not search(r'#\s*define|typedef', function_call)):
1342                error(line_number, 'whitespace/parens', 4,
1343                      'Extra space before ( in function call')

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.