[Webkit-unassigned] [Bug 45423] [Gtk] Port tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45423


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77469|review?                     |review-
               Flag|                            |




--- Comment #18 from Martin Robinson <mrobinson at webkit.org>  2010-12-28 16:47:10 PST ---
(From update of attachment 77469)
View in context: https://bugs.webkit.org/attachment.cgi?id=77469&action=review

Looks good. There are a few issues that I can see though.

> WebCore/page/Frame.cpp:865
> -    unsigned size = paintedArea.size();
> +    int size = paintedArea.size();

Is this change related?

> WebCore/platform/graphics/gtk/TileGtk.cpp:7
> +   Redistribution and use in source and binary forms, with or without
> +   modification, are permitted provided that the following conditions
> +   are met:

Nit: do you mind adding the asterisks here so that this license block looks like others in this directory?

> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:437
> +    notImplemented();

Is this really notImplemented() or is it an empty implementation? There's a subtle difference.

> WebKit/gtk/webkit/webkitwebsettings.cpp:920
> +    /**
> +     * WebKitWebSettings: enable-tiled-backing-store:
> +     *
> +     * Enable or disable tiled backing store

This documentation should be expanded greatly. What is the tiled backing store and why, as an embedder, would I want to turn it on?

> WebKit/gtk/webkit/webkitwebview.cpp:721
> +        if (frame->tiledBackingStore())
> +                renderFromTiledBackingStore(frame, &context, clipRect);
> +        else
> +#endif
>              frame->view()->paint(&context, rect);

The indentation seems incorrect here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.