[Webkit-unassigned] [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6

Tue Dec 28 15:36:21 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=50867

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77533|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #28 from Martin Robinson <mrobinson at webkit.org>  2010-12-28 15:36:20 PST ---
(From update of attachment 77533)
View in context: https://bugs.webkit.org/attachment.cgi?id=77533&action=review

> WebCore/config.h:139
> +// OS(DARWIN) && PLATFORM(GTK): Many Gtk related files include <libintl.h> or
> +// <glib/gi18n-lib.h>. On Mac, these two include <xlocale.h>. <xclocale.h>
> +// includes <xlocale/_ctype.h>, which uses isacii(). If we disallow ctype, 
> +// we'll have problem.

Small grammar issue here. I'll fix before landing myself.

> WebCore/platform/UUID.cpp:46
> +#elif OS(LINUX) && PLATFORM(CHROMIUM) || OS(DARWIN) && PLATFORM(GTK)

Should have a parenthesis around these. I'll fix when landing.

> WebCore/platform/UUID.cpp:96
> +#elif OS(LINUX) && PLATFORM(CHROMIUM) || OS(DARWIN) && PLATFORM(GTK)

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.