[Webkit-unassigned] [Bug 51671] <VT> and <FF> are not valid JSON whitespace characters

Tue Dec 28 13:50:51 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=51671

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77543|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-12-28 13:50:51 PST ---
(From update of attachment 77543)
View in context: https://bugs.webkit.org/attachment.cgi?id=77543&action=review

The fix looks fine.  But making isAllowedSpace clearer will help make this code easier to understand for future peopel hacking here.

> JavaScriptCore/runtime/LiteralParser.cpp:38
> +static inline bool isAllowedSpace(const UChar c)

Seems this name should more clearly state what type of allowed space this is.  is this a JSON Whitespace?  is this a SomeSpecificSpecNameWhitespace?  It would be best to provide a link next to this function where the list of whitespace chars are defined.  How do I validate that this is the right list when I'm looking at this code a month from now?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.