[Webkit-unassigned] [Bug 51686] [GTK] Closing a window during an onload event can trigger serious GLib warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51686





--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2010-12-28 13:44:14 PST ---
(From update of attachment 77573)
View in context: https://bugs.webkit.org/attachment.cgi?id=77573&action=review

> WebKit/gtk/ChangeLog:13
> +

If this were the problem just reffing the view before emitting the signal would be enough; from our talk I understand that it must survive for a while after this function is finished, which is different. Am I wrong?

> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:255
> +    gboolean isHandled = FALSE;

No need to initialize this, and perhaps you could call it 'dummy'.

> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:267
>  

Aren't you checking for m_closeSoonTimer right before?

> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:268
> +    m_webView->priv->corePage->setGroupName("");

And this?

> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:272
> +    // signal, but our caller my need to send more signals web view. For

'more signals web view'? Missing 'to the'?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.