[Webkit-unassigned] [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50867


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org




--- Comment #26 from David Levin <levin at chromium.org>  2010-12-27 23:52:05 PST ---
(In reply to comment #24)
> (In reply to comment #23)
> > (From update of attachment 77472 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=77472&action=review
> > > WebCore/platform/UUID.cpp:46
> > > +#elif OS(LINUX) && PLATFORM(CHROMIUM) || OS(DARWIN) && PLATFORM(GTK)
> > 
> > Is it possible to use parenthesis here to make this less ambiguous to the reader?
> > 
> 
> you mean
>     #elif (OS(LINUX) && PLATFORM(CHROMIUM)) || (OS(DARWIN) && PLATFORM(GTK))
> Yes, I agree. I like parenthesis. I did have parenthesis before, but Tools/Scripts/check-webkit-style doesn't like them. It told me
>     WebCore/platform/UUID.cpp:46:  Extra space before ( in function call  [whitespace/parens] [4]
> I think that's a bug of check-webkit-style, since && has higher precedence than ||, I just removed parenthesis. To add them back, I have to find how to fix the check-webkit-style problem first :-)

Changes that fail check-webkit-style aren't disallowed. It is advisory that there is likely an issue there. In this case, it thinks there is a function call, but there isn't.



btw, if you'd like to fix check-webkit-style, the issue is in the regex below from Tools/Scripts/webkitpy/style/checkers/cpp.py (which I found by searching for the error text):

1340            if (search(r'\w\s+\(', function_call)
1341                and not search(r'#\s*define|typedef', function_call)):
1342                error(line_number, 'whitespace/parens', 4,
1343                      'Extra space before ( in function call')

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.