[Webkit-unassigned] [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50867





--- Comment #24 from Koan-Sin Tan <koansin.tan at gmail.com>  2010-12-27 16:56:41 PST ---
(In reply to comment #23)
> (From update of attachment 77472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77472&action=review
> 
> Great updates. Sorry that I forgot to explain my webkitdirs.pm comment earlier. I've included that below.
> 

Thanks, I see what you mean this time, will do it.

> > WebCore/config.h:-136
> >  // this breaks compilation of <QFontDatabase>, at least, so turn it off for now
> >  // Also generates errors on wx on Windows, presumably because these functions
> >  // are used from wx headers.
> > -#if !PLATFORM(QT) && !PLATFORM(WX) && !PLATFORM(CHROMIUM)
> 
> Might want to update the comment to explain why this is necessary for GTK+ here too.
>

OK.

> > WebCore/platform/UUID.cpp:46
> > +#elif OS(LINUX) && PLATFORM(CHROMIUM) || OS(DARWIN) && PLATFORM(GTK)
> 
> Is it possible to use parenthesis here to make this less ambiguous to the reader?
> 

you mean
    #elif (OS(LINUX) && PLATFORM(CHROMIUM)) || (OS(DARWIN) && PLATFORM(GTK))
Yes, I agree. I like parenthesis. I did have parenthesis before, but Tools/Scripts/check-webkit-style doesn't like them. It told me
    WebCore/platform/UUID.cpp:46:  Extra space before ( in function call  [whitespace/parens] [4]
I think that's a bug of check-webkit-style, since && has higher precedence than ||, I just removed parenthesis. To add them back, I have to find how to fix the check-webkit-style problem first :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.