[Webkit-unassigned] [Bug 51569] [GTK] EditorClient::generateEditorCommands queues up "null string" commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51569





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2010-12-27 14:35:56 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> > When is this condition ever true?  I would have put an assertion here unless you know a condition in which map key is 0.
> 
> IIRC, some misbehaving GTK+ input methods (which are essentially separate programs) may generate key events with node keyval value (which is used for the keyCode() later on). I wasn't able to reproduce this, but I think not trusting the input method code is the right decision here.

Ah, ok. Sounds good to me.

(In reply to comment #8)
> (In reply to comment #6)
> > Created an attachment (id=77518)
 --> (https://bugs.webkit.org/attachment.cgi?id=77518&action=review) [details] [details]
> > Simplified version of the previous patch
> 
> I've attached a simplified version of the previous patch. It seems keyCode() will call charCode() automatically for keypress events, so it isn't necessary to special-case it.

Ok.  I trust you on this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.