[Webkit-unassigned] [Bug 51490] Cleanup SVG code according to the webkit style rules 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 27 05:57:02 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=51490





--- Comment #12 from Dirk Schulze <krit at webkit.org>  2010-12-27 05:57:01 PST ---
(In reply to comment #10)
> (From update of attachment 77309 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77309&action=review
> > WebCore/svg/SVGSwitchElement.cpp:53
> > +    for (Node* node = firstChild(); node; node = node->nextSibling()) {
> > +        if (node->isSVGElement()) {
> > +            SVGElement* element = static_cast<SVGElement*>(node);
> >              if (element && element->isValid())
> > -                return (n == child); // Only allow this child if it's the first valid child
> > +                return (node == child); // Only allow this child if it's the first valid child

isValid() is just implemented in SVGTest and is const. It just checks for a certain feature.

Uploading a new patch soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list