[Webkit-unassigned] [Bug 44610] Malformed SVG causes crash in updateContainerOffset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44610


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77486|commit-queue-               |commit-queue?
               Flag|                            |




--- Comment #3 from Nikolas Zimmermann <zimmermann at kde.org>  2010-12-27 04:43:36 PST ---
(From update of attachment 77486)
View in context: https://bugs.webkit.org/attachment.cgi?id=77486&action=review

Good approach, r- for a few nitpicks:

> LayoutTests/ChangeLog:7
> +        Test case for recursive svg <use>.
> +        This test case passes if no crash occurs.
> +        https://bugs.webkit.org/show_bug.cgi?id=44610

This text should go below the link to the bug report, instead the bug title should be above the link:

<bug title>
https://bugs.webkit.org/...

<bug description>

> LayoutTests/ChangeLog:10
> +        * svg/dom/recursive-use-expected.txt: Added.
> +        * svg/dom/recursive-use.svg: Added.

I think the testcase should rather go into svg/custom/, we only use svg/dom/ for tests that access any DOM attribute/props.

> WebCore/ChangeLog:9
> +        We should check recursive <use> at the begining of
> +        WebCore::SVGUseElement::buildInstanceTree instead
> +        of at the end of it because the target element's
> +        children may cause infinite recursive <use>.
> +        https://bugs.webkit.org/show_bug.cgi?id=44610

This text should go below the link to the bug report, instead the bug title should be above the link:

<bug title>
https://bugs.webkit.org/...

<bug description>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.