[Webkit-unassigned] [Bug 51311] SegmentedString should provide column position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51311





--- Comment #14 from Peter Rybin <peter.rybin at gmail.com>  2010-12-25 15:32:54 PST ---
> > WebCore/html/parser/HTMLTreeBuilder.cpp:359
> > -HTMLTreeBuilder::HTMLTreeBuilder(HTMLTokenizer* tokenizer, DocumentFragment* fragment, Element* contextElement, FragmentScriptingPermission scriptingPermission, bool usePreHTML5ParserQuirks)
> > +HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLTokenizer* tokenizer, DocumentFragment* fragment, Element* contextElement, FragmentScriptingPermission scriptingPermission, bool usePreHTML5ParserQuirks)

> This part of the change still makes me sad.  If we're going to expose the whole HTMLDocumentParser, they we probably don't need to pass the tokenizer separately since you can get that from the parser.  Maybe we should pass a pointer to the input stream instead?

Totally agree. I would prefer the first -- to get tokenizer from parser. After all it's probably just natural that tokenizer is a part of parser.

Exposing html stream seems less elegant to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.