[Webkit-unassigned] [Bug 50527] [Qt] Background image rendering is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50527





--- Comment #16 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-12-25 14:35:06 PST ---
(From update of attachment 77439)
View in context: https://bugs.webkit.org/attachment.cgi?id=77439&action=review

> WebCore/ChangeLog:8
> +        Special case the simple version of Image::drawTiled in Qt, since we can optimize for the simple QPainter::drawTiledPixmap, rather than go through Image::drawPattern which has to invoke QPainter::drawBrush. 

Could you make this line around 80 chars :-) ?

> WebCore/platform/graphics/qt/ImageQt.cpp:139
> +void Image::drawTiled(GraphicsContext* ctxt, const FloatRect& destRect, const FloatPoint& srcPoint, const FloatSize& scaledTileSize, ColorSpace styleColorSpace, CompositeOperator op)

It would be nice if it was detailed here that the code is not strictly needed but it is an optimization. Maybe such an optimization will not be needed forever.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.