[Webkit-unassigned] [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50867





--- Comment #21 from Koan-Sin Tan <koansin.tan at gmail.com>  2010-12-24 18:14:00 PST ---
(In reply to comment #20)
> (From update of attachment 77407 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77407&action=review
> 
> In general looks fine.  The Cursor re-def looks scary and fragile.
> 

Yes. I know :-)

> > Tools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:35
> > +#if OS(DARWIN) && PLATFORM(GTK)
> > +#define Cursor       QD_Cursor 
> > +#endif
> >  #include "PluginObject.h"
> > +#if OS(DARWIN) && PLATFORM(GTK)
> > +#undef Cursor
> > +#endif
> 
> Why is this needed?

To avoid typedef conflict. PluginObject.h will include WebCore/bridge/npapi.h and include QuickDraw stuff, which will typedef Cursor, and X11/Xlib.h wil typedef Cursor again. That's the problem.

I tried to avoid including QuickDraw without success. Because many headers in the<ApplicationServices/ApplicationServices.h>, which is used to include QuickDraw, depends on QuickDraw.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.