[Webkit-unassigned] [Bug 51591] [GTK] Disable flash plugin in GtkLauncher when using gtk3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51591





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2010-12-24 13:01:31 PST ---
(From update of attachment 77414)
View in context: https://bugs.webkit.org/attachment.cgi?id=77414&action=review

>> Tools/GtkLauncher/main.c:247
>> +    for (l = plugins; l; l = g_slist_next(l)) {
> 
> Nit: I suggest renaming 'l' (lowercase 'L' character) to some other variable name (maybe p?) because it looks similar to 'I' (capital eye character) for many fonts, including Courier, Helvetica and Lucida Grande. Moreover, 'p' is closer to the word plugin than 'l'.
> 
> Additionally, I suggest inlining the declaration of 'l' in the for-loop initialization clause since its scope is only relevant within the loop body.

Moving the declaration of 'l' may produce a warning since this file is compiled with -ansi. If that's the case, I'm in favor of dropping -ansi. We should be using c99 at this point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.