[Webkit-unassigned] [Bug 51596] [Windows 7 Release Tests] http/tests/xmlhttprequest/basic-auth-nouser.html and basic-auth-nopassword.html failing since introduction in r74609

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51596





--- Comment #7 from Jessie Berlin <jberlin at webkit.org>  2010-12-24 12:41:25 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Right now the only connection to a Windows machine I have is a remote connection, so it will take me a bit to do any further debugging (so painfully slow ...)
> 
> The problem appears to be in LayoutTestController::queueLoad() itself:
> 
>     // FIXME: We should do real relative URL resolution here.
>     int lastSlash = responseURL.rfind('/');
>     if (lastSlash != -1)
>         responseURL = responseURL.substr(0, lastSlash);
> 
>     wstring wURL = jsStringRefToWString(url);
>     wstring wAbsoluteURL = responseURL + TEXT("/") + wURL;
> 
> I haven't actually executed this code (No easy access to a Windows box here either at the moment), but since wURL at that point is the URL input to queueLoad(), responseURL will be "/xmlhttprequest/". The code appears to attempt to generate an absolute URL out of a relative one.

responseURL is actually "ile:///C:/cygwin/home/jessieberlin/WebKit/OpenSource/LayoutTests/http/tests/xmlhttprequest/"

(since it is rfind and this is actually what I saw when stepping through the function). I don't know why it later is truncated to /xmlhttprequest/.

I would be fine with changing it to check if the URL is absolute. I will try out that solution when I get the windows machine to respond and see if it breaks anything else.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.