[Webkit-unassigned] [Bug 25057] remove rangeCompliantEquivalent and replace it with Position methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25057





--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org>  2010-12-24 11:46:19 PST ---
(In reply to comment #12)
> (From update of attachment 75931 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75931&action=review
> 
> > WebCore/dom/Position.cpp:151
> > +Position Position::parentAnchoredEquivalent() const
> 
> When I started with Position re-writes of yore, Darin Adler raised the concern that every time we return a Posiion object we do a ref-thrash to the underlying node, since we don't have any PassPosition concept.  Obviously PassPosition is a separate patch, but you should be aware, there may be ref-thrash when returning Position objects.

This patch wouldn't regress the performance though because the function we're replacing also returns Position.  Ideally, we can remove this function entirely once we cleaned up other editing code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.