[Webkit-unassigned] [Bug 50869] [cairo] Rendering a lot of arcs on top of each other causes time outs in some tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50869


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77010|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2010-12-24 11:02:50 PST ---
(From update of attachment 77010)
View in context: https://bugs.webkit.org/attachment.cgi?id=77010&action=review

> WebCore/ChangeLog:10
> +        We avoid the situation where we have to render the same arc
> +        multiple times over itself. Now it renders just one oval and
> +        moves to the end angle.
> +

Are we guaranteed that this will produce the proper rendering? What if the stroke is partially opaque? Is this hitting some weird slow path in Cairo? Maybe it would be more accurate to break the stroke up into pieces and render them in a loop?

> WebCore/platform/graphics/cairo/PathCairo.cpp:154
> +    float sweep = ea - sa;

This is a good opportunity to expand variable names into something more readable.

> WebCore/platform/graphics/cairo/PathCairo.cpp:163
> +    } else

It's appropriate to use a "{" here since the block is more than one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.