[Webkit-unassigned] [Bug 51311] SegmentedString should provide column position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51311


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77247|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Adam Barth <abarth at webkit.org>  2010-12-24 10:20:11 PST ---
(From update of attachment 77247)
View in context: https://bugs.webkit.org/attachment.cgi?id=77247&action=review

Thanks for sticking with this patch.  Some minor nits below.

> WebCore/html/parser/HTMLTreeBuilder.cpp:359
> -HTMLTreeBuilder::HTMLTreeBuilder(HTMLTokenizer* tokenizer, DocumentFragment* fragment, Element* contextElement, FragmentScriptingPermission scriptingPermission, bool usePreHTML5ParserQuirks)
> +HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLTokenizer* tokenizer, DocumentFragment* fragment, Element* contextElement, FragmentScriptingPermission scriptingPermission, bool usePreHTML5ParserQuirks)

This part of the change still makes me sad.  If we're going to expose the whole HTMLDocumentParser, they we probably don't need to pass the tokenizer separately since you can get that from the parser.  Maybe we should pass a pointer to the input stream instead?

> WebCore/html/parser/HTMLTreeBuilder.cpp:2783
> +    ScriptableDocumentParser* parserUpcast = m_parser;
> +    TextPosition0 position = parserUpcast->textPosition();

I don't understand why wer need to do this casting.  Isn't textPosition available on HTMLDocumentParser directory?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.