[Webkit-unassigned] [Bug 50018] MathML: vertical alignment & bar thickness adjustments of fractions are needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50018


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74749|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-12-24 03:01:19 PST ---
(From update of attachment 74749)
View in context: https://bugs.webkit.org/attachment.cgi?id=74749&action=review

Please respond to or  fix these comments before landing.

> WebCore/ChangeLog:8
> +        Adjustments of the fraction bar default thickness and vertical alignment.
> +        https://bugs.webkit.org/show_bug.cgi?id=50018
> +
> +        Test: mathml/presentation/fractions.xhtml

It would be nice if you explained what change you actually made. Like why is this new change more correct?

> WebCore/mathml/RenderMathMLFraction.cpp:145
> +        int adjustForThickness = m_lineThickness > 1 ? static_cast<int>(m_lineThickness / 2) : 1;

Why static_cast<int> and not just int(m_lineThickness / 2) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.