[Webkit-unassigned] [Bug 51241] [GTK] PlatformRefPtr should not be used with Gtk widgets

Fri Dec 24 02:52:26 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=51241

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2010-12-24 02:52:26 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > 
> > > In this case it should still be appropriate for situations where WebKit wants to control the lifetime of the GTK+ object or if it's shared between WebKit classes. For instance, ContextMenu isn't copyable, but if it was we would want the menu widget to be a PlatformRefPtr.
> > 
> > Sure, as I said in the bug description there are some situations where using PlatformRefPtr with widgets is correct.
> 
> How did you find this? Review or did it misbehave?

I noticed it when I was working on bug #49658, then I reviewed all other cases where PlatformRefPtr was used with widgets. There's no misbehaviour actually since it works, but it's not how gtk widgets are expected to work and it makes the code confusing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.